Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add utility methods for creating and comparing OCI descriptors #281

Merged
merged 11 commits into from
Sep 1, 2022
Merged

feat: add utility methods for creating and comparing OCI descriptors #281

merged 11 commits into from
Sep 1, 2022

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Aug 25, 2022

This pr implements GenerateDescriptor and Equal.

See #240
Resolves #275

Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #281 (628d3a2) into main (2946dfc) will increase coverage by 0.09%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   70.77%   70.87%   +0.09%     
==========================================
  Files          36       37       +1     
  Lines        3357     3368      +11     
==========================================
+ Hits         2376     2387      +11     
  Misses        734      734              
  Partials      247      247              
Impacted Files Coverage Δ
copy.go 60.78% <50.00%> (ø)
descriptor/descriptor.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 2ae35d3 into oras-project:main Sep 1, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the descriptor branch September 1, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility methods for manipulating descriptors
4 participants