Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed to open a read-only OCI store if index.json doesn't exist #449

Closed
qweeah opened this issue Feb 21, 2023 · 2 comments · Fixed by #450
Closed

failed to open a read-only OCI store if index.json doesn't exist #449

qweeah opened this issue Feb 21, 2023 · 2 comments · Fixed by #450

Comments

@qweeah
Copy link
Contributor

qweeah commented Feb 21, 2023

oci.NewFromFS and oci.NewFromTar will always validate the existence of index.json. We might need to loose this check since it is possible to have an OCI image layout with only blobs but no manifest stored.
@qweeah qweeah changed the title failed to read blob from read-only OCI store if index.json doesn't exist failed to open a read-only OCI store if index.json doesn't exist Feb 21, 2023
@Wwwsylvia
Copy link
Member

Wwwsylvia commented Feb 23, 2023 •
edited
Loading

index.json is a required file for OCI layout.
Instead of relaxing the check, I think we should automatically generate the index.json even if there is no manifest stored in the layout.

@Wwwsylvia Wwwsylvia mentioned this issue Feb 23, 2023
Merged
shizhMSFT pushed a commit that referenced this issue Feb 24, 2023
@Wwwsylvia
fix: ensure index.json for oci store (#450)
216f081 
Fixes: #449
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@qweeah
Copy link
Contributor Author

qweeah commented Feb 24, 2023

automatically generate the index.json even if there is no manifest stored in the layout.

👍indeed, just double checked the OCI spec, indes.json MUST exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure index.json for oci store Wwwsylvia/oras-go
2 participants
@qweeah @Wwwsylvia