Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Org certificate library #962

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat: Add Org certificate library #962

merged 2 commits into from
Jan 27, 2025

Conversation

azrod
Copy link
Member

@azrod azrod commented Jan 16, 2025 •
edited
Loading

Co-authored-by: David MICHENEAU david.micheneau@orange.com<

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

--- PASS: TestAccOrgCertificateLibraryDatasource (10.09s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  10.663s

--- PASS: TestAccORGCertificateLibraryResource (13.87s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  14.872s

@github-actions github-actions bot added the feature New feature label Jan 16, 2025
@github-actions github-actions bot added the size/XL Extra large PR label Jan 16, 2025
@azrod azrod force-pushed the 904-new-datasource-org-certificate-library branch from a8aa811 to 250bb57 Compare January 16, 2025 17:40
@github-actions github-actions bot added size/L Large PR and removed size/XL Extra large PR labels Jan 16, 2025
@azrod azrod force-pushed the 904-new-datasource-org-certificate-library branch 2 times, most recently from fd60be7 to e56d097 Compare January 16, 2025 17:59
@azrod azrod changed the title feat: Add ALB Service Engine Group datasource (#900) feat: Add Org certificate library Jan 16, 2025
@azrod azrod added new-resource New resource new-datasource New datasource labels Jan 16, 2025
@azrod azrod force-pushed the 904-new-datasource-org-certificate-library branch from e56d097 to 13faa39 Compare January 16, 2025 18:08
@azrod azrod marked this pull request as ready for review January 16, 2025 18:08
@azrod azrod requested a review from a team as a code owner January 16, 2025 18:08
dmicheneau
dmicheneau approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@dmicheneau dmicheneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to

@azrod azrod force-pushed the 904-new-datasource-org-certificate-library branch from 13faa39 to 3abb904 Compare January 27, 2025 11:11
@azrod azrod force-pushed the 904-new-datasource-org-certificate-library branch from 92cdbc1 to 1ab991c Compare January 27, 2025 13:41
@azrod azrod merged commit 55cf19c into ALB Jan 27, 2025
9 checks passed
@azrod azrod deleted the 904-new-datasource-org-certificate-library branch January 27, 2025 13:51
@azrod azrod linked an issue Jan 27, 2025 that may be closed by this pull request
[New Resource/DataSource]: cloudavenue_org_certificate_library #904
Closed
azrod added a commit that referenced this pull request Jan 31, 2025
@azrod
feat: Add Org certificate library (#962)
aa25568 
Co-authored-by: David MICHENEAU <david.micheneau@orange.com>
azrod added a commit that referenced this pull request Feb 5, 2025
@azrod
feat: Add Org certificate library (#962)
6b16173 
Co-authored-by: David MICHENEAU <david.micheneau@orange.com>
azrod added a commit that referenced this pull request Feb 5, 2025
@azrod
feat: Add Org certificate library (#962)
624e866 
Co-authored-by: David MICHENEAU <david.micheneau@orange.com>
azrod pushed a commit that referenced this pull request Feb 17, 2025
@dmicheneau @azrod
feat: Add ALB Service Engine Group datasource (#900)
bf666b5 
Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org Certificate Library datasource

feat: remove sdk depend

feat: Add ALB Service Engine Group datasource (#911)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org certificate library (#962)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

chore: refacto certificate to new SDK struct

refactor: LB service engine to new SDK (#979)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore: rename alb to elb (#980)

feat(elb): add ress/data `cloudavenue_elb_pool` (#981)

feat: add ress/data `elb_virtual_service` (#985)
azrod pushed a commit that referenced this pull request Feb 17, 2025
@dmicheneau @azrod
feat: Add ALB Service Engine Group datasource (#900)
b13592f 
Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org Certificate Library datasource

feat: remove sdk depend

feat: Add ALB Service Engine Group datasource (#911)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org certificate library (#962)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

chore: refacto certificate to new SDK struct

refactor: LB service engine to new SDK (#979)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore: rename alb to elb (#980)

feat(elb): add ress/data `cloudavenue_elb_pool` (#981)

feat: add ress/data `elb_virtual_service` (#985)
azrod pushed a commit that referenced this pull request Feb 17, 2025
@dmicheneau @azrod
feat: Add ALB Service Engine Group datasource (#900)
4d7d8ca 
Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org Certificate Library datasource

feat: remove sdk depend

feat: Add ALB Service Engine Group datasource (#911)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org certificate library (#962)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

chore: refacto certificate to new SDK struct

refactor: LB service engine to new SDK (#979)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore: rename alb to elb (#980)

feat(elb): add ress/data `cloudavenue_elb_pool` (#981)

feat: add ress/data `elb_virtual_service` (#985)
azrod pushed a commit that referenced this pull request Feb 17, 2025
@dmicheneau @azrod
feat: Add ALB Service Engine Group datasource (#900)
ebb67e0 
Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org Certificate Library datasource

feat: remove sdk depend

feat: Add ALB Service Engine Group datasource (#911)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org certificate library (#962)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

chore: refacto certificate to new SDK struct

refactor: LB service engine to new SDK (#979)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore: rename alb to elb (#980)

feat(elb): add ress/data `cloudavenue_elb_pool` (#981)

feat: add ress/data `elb_virtual_service` (#985)
azrod pushed a commit that referenced this pull request Feb 17, 2025
@dmicheneau @azrod
feat: Add ALB Service Engine Group datasource (#900)
417cf3a 
Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org Certificate Library datasource

feat: remove sdk depend

feat: Add ALB Service Engine Group datasource (#911)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

feat: Add Org certificate library (#962)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>

chore: refacto certificate to new SDK struct

refactor: LB service engine to new SDK (#979)

Co-authored-by: David MICHENEAU <david.micheneau@orange.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore: rename alb to elb (#980)

feat(elb): add ress/data `cloudavenue_elb_pool` (#981)

feat: add ress/data `elb_virtual_service` (#985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau approved these changes

Assignees

@azrod azrod

Labels
feature New feature new-datasource New datasource new-resource New resource size/L Large PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource/DataSource]: cloudavenue_org_certificate_library
2 participants
@azrod @dmicheneau