Extract SettingsHelper from SearchHelper #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5120
💛 - Coveralls |
tulinkry
reviewed
Apr 29, 2020
| } | ||
|
|
||
| String k = projectName != null ? projectName : ""; | ||
| return mappedAnalysisSettings.get(k); |
There was a problem hiding this comment.
k is not very descriptive
| */ | ||
| public Map<String, IndexedSymlink> getSymlinks(String projectName) { | ||
| if (mappedIndexedSymlinks == null) { | ||
| throw new IllegalStateException("getSettings() not yet called"); |
There was a problem hiding this comment.
is it problem to call it here getSettings()?
There was a problem hiding this comment.
No doesn't seem so
ktulinger
approved these changes
Apr 30, 2020
|
lgtm, merging |
|
Thank you for the reviews, @ktulinger and @tarzanek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider for integration this patch to extract
SettingsHelperfromSearchHelper. This is from open PR #2732 and is a pre-requisite to a number of ready features, including search context and directory #LinesLOC.Thank you.