pkg/helm: add option to watch dependent resources #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
joelanford
requested review from
shawn-hurley,
lilic,
hasbro17,
estroz and
AlexNPavel
…ips between owner and child resources
hasbro17
reviewed
Jan 11, 2019
estroz
approved these changes
Jan 11, 2019
| GVK: gvk, | ||
| ManagerFactory: factory, | ||
| ReconcilePeriod: helmOperatorFlags.ReconcilePeriod, | ||
| WatchDependentResources: true, |
There was a problem hiding this comment.
Should watching dependent resources be configurable, or is this always being true fine for up local purposes?
There was a problem hiding this comment.
It probably makes sense to make this configurable in both the up local and in-cluster scenarios.
Since this is also a feature of the ansible operator, how about we do a follow-up PR to add a flag for this to the pkg/internal/flags.WatchFlags struct?
@shawn-hurley, any input from the ansible operator perspective (or otherwise)?
hasbro17
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adding option to enable watches of dependent resources of Helm releases.
Motivation for the change:
Currently, the helm operator must perform a periodic reconciliation to ensure that dependent resources do not drift from their release manifest. This periodic reconciliation is often a no-op since no changes have occurred. This PR will reduce resource utilization in the operator and against the API server by eliminating the need for periodic reconciliation.