adds migrate command and ansible base image scaffolds #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrivnak
added
kind/feature
openshift-ci-robot
added
the
size/XL
|
I'll add docs for this, but want to vet the general approach first, and also ensure we are happy enough with the contents of |
mhrivnak
force-pushed
the
source
branch
2 times, most recently
from
973babc to
fe8fc7f
Compare
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
The `operator-sdk migrate` command adds go source and other files necessary to convert an ansible operator to a hybrid operator. The scaffolds used for `migrate` are also made available for use in creating the ansible-operator base image through `commands/ansible-operator-base/main.go`.
dymurray
reviewed
Jan 7, 2019
| exit 1 | ||
| fi | ||
|
|
||
| ## TODO enable when this is fixed: https://github.com/operator-framework/operator-sdk/issues/818 |
There was a problem hiding this comment.
I believe this can be added back. I've commented on the issue.
dymurray
approved these changes
Jan 7, 2019
| kubectl logs deployment/${memcached_deployment} | ||
| exit 1 | ||
| fi | ||
| deploy_operator |
There was a problem hiding this comment.
+1 to wrapping all this in functions.
AlexNPavel
reviewed
Jan 7, 2019
|
I am going to submit a new PR that takes a different approach to building the ansible operator binary itself. As discussed elsewhere, it will add a The |
typo fix Co-Authored-By: mhrivnak <mhrivnak@hrivnak.org>
|
Here's the new PR that obsoletes this one: #887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
operator-sdk migratecommand adds go source and other files necessary toconvert an ansible operator to a hybrid operator.
The scaffolds used for
migrateare also made available for use in creatingthe ansible-operator base image through
commands/ansible-operator-base/main.go.