Scorecard finalizer fix #2597
Merged
Scorecard finalizer fix #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2020 16:22
…itTimeout configuration setting
openshift-ci-robot
added
the
size/M
jmccormick2001
requested review from
camilamacedo86 and
jmrodri
and removed request for
joelanford and
shawn-hurley
There was a problem hiding this comment.
Hi @jmccormick2001,
It shows great 👍. Just few nits.
- See the comments
- Missing CHANGELOG
- Also, could we not add the config initTimeout in its docs?
camilamacedo86
added
kind/bug
…alue with config init-timeout value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
make the scorecard cleanup use the init-timeout configuration setting when doing its cleanup, this will allow operators that specify a finalizer to have time to perform their cleanup based on a configurable value instead of the previous hard-coded value.
Motivation for the change:
Closes #2094