Helm: fix misleading "release not found" errors during CR deletion #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
joelanford
added
language/helm
joelanford
force-pushed
the
helm-uninstall-bug
branch
from
6513655 to
ed02f75
Compare
camilamacedo86
approved these changes
Jan 6, 2020
theishshah
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
When reconciling deleted Helm operator CRs, wait for the CR to be deleted from the cache before returning. Also improve the error handling to take advantage of Helm v3's new
ErrReleaseNotFoundMotivation for the change:
Closes #2342