Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/operator-sdk/olmcatalog: gen-csv must run in project root #2322

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Dec 11, 2019

Description of the change: ensure gen-csv is run in the project root.

Motivation for the change: see #2081

Closes #2081

@estroz estroz added the olm-integration Issue relates to the OLM integration label Dec 11, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2019
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

🥇

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@estroz estroz changed the title cmd/operator-sdk/olmcatalog: ensure gen-csv is run in the project root cmd/operator-sdk/olmcatalog: gen-csv must run in project root Dec 12, 2019
@estroz estroz merged commit bbb91b5 into operator-framework:master Dec 12, 2019
@estroz estroz deleted the bugfix/issue-2081 branch December 12, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
olm-integration Issue relates to the OLM integration size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gen-csv should be able to find the deploy folder instead of creating a new one
4 participants