Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version,cmd/operator-sdk/version: add go version, os, and arch #1863

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

joelanford
Copy link
Member

Description of the change:
Adds the version, OS, and architecture of the Go compiler that was used to build the operator-sdk binary

Motivation for the change:
To make it easier to debug problems that may be a result of differences in Go versions used to build and run the SDK.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2019
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2019
@joelanford
Copy link
Member Author

Any concerns with quoting the version/commit strings? If anyone is parsing this, it will break them. I'd consider this porcelain though, so I wouldn't call this a breaking change. Thoughts?

Also, I'll add another commit for the CHANGELOG.

joelanford added a commit to joelanford/operator-sdk that referenced this pull request Aug 26, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2019
@joelanford
Copy link
Member Author

/test e2e-aws-helm
/test images

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2019
@joelanford
Copy link
Member Author

/test images
/test e2e-aws-helm
/test e2e-aws-ansible

@joelanford joelanford merged commit 8e55eb7 into operator-framework:master Aug 27, 2019
@joelanford joelanford deleted the go-version branch August 27, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants