Make generated inventory define implicit localhost #1828
Conversation
openshift-ci-robot
added
the
size/XS
fabianvf
force-pushed
the
implicit-localhost
branch
from
c19dd03 to
9ca57ea
Compare
CHANGELOG.md
Outdated
| @@ -58,6 +58,7 @@ | |||
| - Configure the repo path correctly in `operator-sdk add crd` and prevent the command from running outside of an operator project. ([#1660](https://github.com/operator-framework/operator-sdk/pull/1660)) | |||
| - In the Helm operator, skip owner reference injection for cluster-scoped resources in release manifests. The Helm operator only supports namespace-scoped CRs, and namespaced resources cannot own cluster-scoped resources. ([#1817](https://github.com/operator-framework/operator-sdk/pull/1817)) | |||
| - Package manifests generated with [`gen-csv`](https://github.com/operator-framework/operator-sdk/blob/master/doc/sdk-cli-reference.md#gen-csv) respect the `--operator-name` flag, channel names are checked for duplicates before (re-)generation. ([#1693](https://github.com/operator-framework/operator-sdk/pull/1693)) | |||
| - Generated inventory for Ansible-based Operators now sets the localhost's `ansible_python_interpreter` to `{{ ansible_playbook_python }}`, to properly match the [implicit localhost](https://docs.ansible.com/ansible/latest/inventory/implicit_localhost.html). | |||
There was a problem hiding this comment.
| - Generated inventory for Ansible-based Operators now sets the localhost's `ansible_python_interpreter` to `{{ ansible_playbook_python }}`, to properly match the [implicit localhost](https://docs.ansible.com/ansible/latest/inventory/implicit_localhost.html). | |
| - Generated inventory for Ansible-based Operators now sets the localhost's `ansible_python_interpreter` to `{{ ansible_playbook_python }}`, to properly match to the [implicit localhost](https://docs.ansible.com/ansible/latest/inventory/implicit_localhost.html). ([#1828](https://github.com/operator-framework/operator-sdk/pull/1828))``` |
There was a problem hiding this comment.
Just a small nit ^ and all is ok.
fabianvf
force-pushed
the
implicit-localhost
branch
from
9ca57ea to
80eb43b
Compare
|
/lgtm |
camilamacedo86
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
23 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Upgrade Ansible based images (python and its lib as ansible and molecule) * Download and install the inotify-tools which is no longer available in the ubi8//epel-release-latest-8 * use pip3 in all places * changes in the ci/trevis in order to work with python3 * ajust pip and python to work in ubi7 * increase the timeout to check the reconcile ( 2m for reconciliation to run ) * upgrade ansible and its deps versions * upgrade to use molecule 2.22 * apply to make generated inventory define implicit localhost #1828 * add ansible_python_interpreter=/usr/bin/python3 in host inventory * solve ansible [WARNING]: The value 8443 (type int) * improve test names in order to be able to identify them * add interpreter in the py file (plugin filter) * add host var for all hosts in the molecule inventory * add yum update to address request made in the pr #1979 * using ansible as ~=2.8
|
New changes are detected. LGTM label has been removed. |
Description of the change:
Makes localhost default to the same python interpreter as the one that is running ansible
Motivation for the change:
Our generated inventory wasn't setting the default ansible python interpreter for localhost to match Ansible's implicit localhost, which made running up local difficult.
closes #1437
Thanks to @nmasse-itix