cmd/operator-sdk/add/controller.go: support built-in k8s API controllers #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built-in Kubernetes API controllers internal/pkg/scaffold/controller_kind*.go: set imports at runtime as to respect a Kubernetes API controller import
estroz
requested review from
joelanford,
AlexNPavel,
lilic,
hasbro17 and
theishshah
openshift-ci-robot
added
the
size/M
lilic
suggested changes
Apr 24, 2019
openshift-ci-robot
added
size/L
and optionally an import identifier for an expernal k8s API internal/pkg/scaffold/controller_kind*.go: parse and set K8sImport in template
estroz
force-pushed
the
k8s-api-controllers
branch
from
e974c1a to
ff140ab
Compare
lilic
suggested changes
May 7, 2019
openshift-ci-robot
added
the
needs-rebase
joelanford
approved these changes
May 16, 2019
Co-Authored-By: Joe Lanford <joe.lanford@gmail.com>
openshift-ci-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
cmd/operator-sdk/add/controller.go: --k8s-api-import for scaffolding built-in and external Kubernetes API controllersinternal/pkg/scaffold/controller_kind*.go: set imports at runtime as to respect an API importMotivation for the change: See #928 and #1343
Closes #1343