Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands/.../scorecard: optionally use only a CSV manifest when deployed with OLM #1044

Merged
merged 42 commits into from
Feb 28, 2019
Merged

commands/.../scorecard: optionally use only a CSV manifest when deployed with OLM #1044

merged 42 commits into from
Feb 28, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Feb 1, 2019 •
edited
Loading

Description of the change: added olm-deployed flag to direct the scorecard command to only use the CSV at csv-path for manifest data.

Motivation for the change: OLM-deployed operators may only have a CSV and CRD's available on disk, ex. automation-broker. The scorecard cannot assume that a deploy dir with SDK-generated contents will be available.

@estroz estroz added kind/feature Categorizes issue or PR as related to a new feature. scorecard Issue relates to the scorecard subcomponent olm-integration Issue relates to the OLM integration labels Feb 1, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 1, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 1, 2019
@estroz estroz requested review from joelanford and lilic February 6, 2019 22:33
@estroz estroz force-pushed the olm-scorecard-integration branch from 09caf1d to 81e425f Compare February 12, 2019 22:51
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 13, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2019
@estroz estroz changed the title commands/.../scorecard: optionally use only a CSV manifest for scorecard commands/.../scorecard: optionally use only a CSV manifest when deployed with OLM Feb 18, 2019
@estroz estroz mentioned this pull request Feb 18, 2019
Closed
AlexNPavel
AlexNPavel approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@AlexNPavel AlexNPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasbro17
Copy link
Contributor

Can you also please update the cli-reference-guide and the CHANGELOG for the olm-deployed flag.

hasbro17
hasbro17 approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit f287813 into operator-framework:master Feb 28, 2019
@estroz estroz deleted the olm-scorecard-integration branch February 28, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexNPavel AlexNPavel AlexNPavel approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@joelanford joelanford Awaiting requested review from joelanford

@lilic lilic Awaiting requested review from lilic

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. olm-integration Issue relates to the OLM integration scorecard Issue relates to the scorecard subcomponent size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estroz @hasbro17 @AlexNPavel @openshift-ci-robot