Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experience Composer API enhancements #283

Merged
merged 7 commits into from
Nov 7, 2022
Merged

Experience Composer API enhancements #283

merged 7 commits into from
Nov 7, 2022

Conversation

manchuck
Copy link
Contributor

What is this PR doing?

Adding the render

How should this be manually tested?

opentok.listRenders({}, (err, renders) => {
    if (err) {
        console.log("There was an error")
        console.log(err);
        return;
    }

    console.log(renders);
})

opentok.getRender('<render id>', (err, render) => {
    if (err) {
        console.log("There was an error")
        console.log(err);
        return;
    }

    console.log(render);
})

opentok.startRender(
    {
        sessionId: sessionId,
        token: token,
        url: '<callback url>',
    }, 
    (err, render) => {
        if (err) {
            console.log("There was an error")
            console.log(err);
            return;
        }

        console.log(render);
    }
)

opentok.stopRender('<render id>', (err, render) => {
    if (err) {
        console.log("There was an error")
        console.log(err);
        return;
    }

    console.log(render);
})

What are the relevant tickets?

DEVX-6495

Verified

This commit was signed with the committer’s verified signature.
manchuck Chuck Reeves

Verified

This commit was signed with the committer’s verified signature.
manchuck Chuck Reeves
@manchuck
Copy link
Contributor Author

This is going to need #282 to be closed before moving forward

@pardel pardel requested a review from jeffswartz September 22, 2022 19:10
@jeffswartz jeffswartz changed the title Composer experience Experience Composer API enhancements Sep 26, 2022
Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rev the version number. If this will be bundled with other enhancements, please target the dev branch.

manchuck and others added 2 commits September 27, 2022 14:31

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com>
@manchuck manchuck changed the base branch from main to dev October 3, 2022 15:55

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com>
Copy link
Contributor

@hamzanasir hamzanasir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than adding the docs that @jeffswartz commented it looks good to me!

Verified

This commit was signed with the committer’s verified signature.
manchuck Chuck Reeves
Removed hidden property
@manchuck manchuck mentioned this pull request Oct 14, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@manchuck manchuck merged commit 7cf48e4 into dev Nov 7, 2022
@manchuck manchuck deleted the composer-experience branch November 11, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants