Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhances root list-delegates #49

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

  • Groups v-permits together based on ranges
  • Fully displays ss58 address
  • Changes table to a box
  • Other UI improvements

Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here is a bit weird to follow, and I'd like to see the readability and general flow improved. We shouldn't need so many comments explaining what is happening in the logic, and yet without them, the logic here needs explanation. I think you can improve this.

@ibraheem-opentensor ibraheem-opentensor merged commit 31d8e19 into main Sep 4, 2024
2 of 3 checks passed
@thewhaleking thewhaleking deleted the ui/enhances-root-list-delegates branch September 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants