Table fixes / E2E Test - Senate command fix #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ibraheem-opentensor
commented
Sep 20, 2024
•
ibraheem-opentensor
commented
- Adds --vote-aye/--vote-nay
- Changes layout of stake show (account removed)
- Updates layout of wallet inspect
- Adds guard-rails for pgp
- Finishes senate e2e coverage
ibraheem-opentensor
changed the title
thewhaleking
previously approved these changes
Sep 20, 2024
ibraheem-opentensor
requested review from
garrett-opentensor and
thewhaleking
roman-opentensor
approved these changes
Sep 21, 2024
ibraheem-opentensor
added a commit
that referenced
this pull request
Sep 21, 2024
* Init commit * Fixes table * Working * Adds back Hotkey * Adds separation in overview * WIP: Senate * Finishes senate e2e * Fixes tests
ibraheem-opentensor
added a commit
that referenced
this pull request
Sep 23, 2024
* Adds support for passing comma sep values * Adds func to salt * Seventh set of Typer docstrings * Table fixes / E2E Test - Senate command fix (#100) * Init commit * Fixes table * Working * Adds back Hotkey * Adds separation in overview * WIP: Senate * Finishes senate e2e * Fixes tests * Update help. * Ruff * Give user their UID immediately after root/sn registration. (#108) * Give user the UID immediately after root registration. * Subnet register * Don't check size of PGP fingerprint if it's not set (#110) * Give user the UID immediately after root registration. * Only check size of PGP fingerprint if it's actually set. * Enhancement: max-stake and table tweak (#105) * Enhances max_stake and column change in list-delegates * Ruff * Ruff --------- Co-authored-by: Benjamin Himes <benhimes@opentensor.dev> * Propagates list supp, exists in-case of no subnet in sudo set, fixes staking multiple * Ruff * Adds support for both hotkeys and ss58s * Updated help docstring for stake_remove to reflect new list style --------- Co-authored-by: Watchmaker <rajk@opentensor.dev> Co-authored-by: Benjamin Himes <benhimes@opentensor.dev> Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.