Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change direction of red_turn when way is reversed #10737

Conversation

burrscurr
Copy link
Contributor

Resolves #10736.

The PR also includes additional tests for reversal of turn:lanes tags and some refactoring to reduce the number of return paths in reverseValue function. (Those are all split into different commits.)

@burrscurr burrscurr changed the title Don't change direction of red turn when reversing way Don't change direction of red_turn when reversing way Feb 5, 2025
@burrscurr burrscurr changed the title Don't change direction of red_turn when reversing way Don't change direction of red_turn when way is reversed Feb 8, 2025
@tyrasd tyrasd added bug A bug - let's fix this! operation An editing operation / edit menu item labels Feb 13, 2025
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, especially for the added tests cases and the cleanup of the different exceptions we had defined all over the module!

@tyrasd tyrasd merged commit 6b82c58 into openstreetmap:develop Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! operation An editing operation / edit menu item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reversing a way changes direction of red turn
2 participants