Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the turn restriction editor not supporting bidirectional roads #10731

Merged
merged 1 commit into from
Feb 12, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -48,6 +48,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
#### :bug: Bugfixes
* Prevent degenerate ways caused by deleting a corner of a triangle ([#10003], thanks [@k-yle])
* Fix briefly disappearing data layer during background layer tile layer switching transition ([#10748])
* Fix the turn restriction editor not supporting bidirectional roads ([#10731], thanks [@k-yle])
* Preserve imagery offset during tile layer switching transition ([#10748])
* Fix over-saturated map tiles near the border of the tile service's coverage area ([#10747], thanks [@hlfan])
* Fix too dim markers of selected/hovered photo of some street level imagery layers ([#10755], thanks [@draunger])
@@ -60,6 +61,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
[#7381]: https://github.com/openstreetmap/iD/issues/7381
[#10003]: https://github.com/openstreetmap/iD/pull/10003
[#10720]: https://github.com/openstreetmap/iD/issues/10720
[#10731]: https://github.com/openstreetmap/iD/pull/10731
[#10747]: https://github.com/openstreetmap/iD/issues/10747
[#10748]: https://github.com/openstreetmap/iD/issues/10748
[#10755]: https://github.com/openstreetmap/iD/issues/10755
3 changes: 2 additions & 1 deletion modules/osm/intersection.js
Original file line number Diff line number Diff line change
@@ -211,7 +211,8 @@ export function osmIntersection(graph, startVertexId, maxDistance) {
// walking the intersection graph later and rendering turn arrows.

function withMetadata(way, vertexIds) {
var __oneWay = way.isOneWay();
// bidirectional ways are two-way from an intersection's perspective
var __oneWay = way.isOneWay() && !way.isBiDirectional();

// which affixes are key vertices?
var __first = (vertexIds.indexOf(way.first()) !== -1);