refactor isOneWay to properly support bidirectional ways
#10730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
approved these changes
Feb 6, 2025
tyrasd
reviewed
Feb 6, 2025
k-yle
force-pushed
the
kh/refactor-oneway
branch
from
146ce44 to
8efc590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblocks #10731
The code which handles
oneway=-1andoneway=alternatingis a bit confusing and has hardcoded tags in different parts of the codebase.This PR refactors the logic into 3 methods:
isOneWayForwards,isOneWayBackwards,isBiDirectional