Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix relation membership list using a non-deterministic order #10648

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Jan 3, 2025

When selecting a way, the list of relations uses an unpredictable order.

This is annoying, but more importantly, it causes a rare bug: You can't merge ways if the relations were added in a different order.

For example, merging these ways:..

image image

...will cause an unexpected error:

image

@k-yle k-yle force-pushed the kh/membership-order branch 4 times, most recently from 7729c1e to 0867cf0 Compare January 6, 2025 22:44
@k-yle k-yle force-pushed the kh/membership-order branch from 0867cf0 to ff8f044 Compare January 7, 2025 22:03
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry. Otherwise it look good!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@k-yle k-yle force-pushed the kh/membership-order branch from ff8f044 to 9731ba0 Compare February 12, 2025 09:12
@tyrasd tyrasd added bug A bug - let's fix this! usability An issue with ease-of-use or design labels Feb 12, 2025
@tyrasd tyrasd merged commit bd85d31 into develop Feb 12, 2025
4 checks passed
@tyrasd tyrasd deleted the kh/membership-order branch February 12, 2025 14:17
@Dimitar5555
Copy link
Contributor

This PR should resolve #9502 and #9788, correct?

@tyrasd
Copy link
Member

tyrasd commented Feb 12, 2025

I'd think so. @k-yle can you double-check this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! usability An issue with ease-of-use or design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants