Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public solution subset #3906

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Add public solution subset #3906

merged 4 commits into from
Jan 25, 2024

Conversation

TylerZeroMaster
Copy link
Contributor

Summary

  • New tag with dropdown that supports values even and odd
  • Dropdown is only visible when question is multi-part and solutions are public
  • Tag is optional: when it is not set, that means all solutions are public
  • When conditions for the dropdown appearing are not met, the value for the tag should be cleared

@TylerZeroMaster
Add public-solutions-subset tag
8916153 
Tag is removed when isMultiPart is toggled off.
@TylerZeroMaster
Add public-solution-subset dropdown
3c98f97 
- Only appears when question is multipart and solutions are public
- Tag value is cleared when solutions are made private
@TylerZeroMaster
Update tests to include public-solutions-dropdown
8b081bc 
- Ensure tag value is managed correctly
- Ensure dropdown only appears when solutions are public and question is multi-part
@TylerZeroMaster
Ensure solutionIsPublic starts unchecked
7890f06
@TylerZeroMaster TylerZeroMaster requested a review from a team as a code owner January 23, 2024 21:00
@TylerZeroMaster TylerZeroMaster requested review from jivey and philschatz and removed request for a team and jivey January 23, 2024 21:00
philschatz
philschatz approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@philschatz philschatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TylerZeroMaster TylerZeroMaster merged commit 514c710 into main Jan 25, 2024
5 of 6 checks passed
@TylerZeroMaster TylerZeroMaster deleted the public-solution-subset branch January 25, 2024 20:35
@TylerZeroMaster TylerZeroMaster self-assigned this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philschatz philschatz philschatz approved these changes

@therealmarv therealmarv Awaiting requested review from therealmarv

@sparksam sparksam Awaiting requested review from sparksam

Assignees

@TylerZeroMaster TylerZeroMaster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerZeroMaster @philschatz