Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix response validation flexbox issue #3749

Merged
merged 3 commits into from
Sep 10, 2021
Merged

Conversation

jivey
Copy link
Member

@jivey jivey commented Sep 7, 2021

Fixes an alignment bug with the response validator text by always using space-between.

Old:
image

New:
image

@jivey jivey self-assigned this Sep 7, 2021
@jivey jivey requested a review from a team as a code owner September 7, 2021 17:37
@jivey jivey requested review from Dantemss and a team and removed request for a team September 7, 2021 17:37
@jivey jivey force-pushed the fix-response-validation-flex branch from 94e49b4 to f8c5600 Compare September 7, 2021 17:39
Copy link
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you intentionally limiting the width of the left section? you could leave the justification constant and put flex: 1 on the left text area if you were ok with it filling the space

@jivey
Copy link
Member Author

jivey commented Sep 8, 2021

are you intentionally limiting the width of the left section? you could leave the justification constant and put flex: 1 on the left text area if you were ok with it filling the space

The Validator text has a max-width there, but didn't really look too closely at it though, maybe the rules could be simplified as you say. I can take a look later today.

@jivey jivey merged commit 8753b93 into main Sep 10, 2021
@jivey jivey deleted the fix-response-validation-flex branch September 10, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants