Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only show createCourse block to authorized users #3659

Merged
merged 1 commit into from
Jun 22, 2021
Merged

only show createCourse block to authorized users #3659

merged 1 commit into from
Jun 22, 2021

Conversation

nathanstitt
Copy link
Member

No idea why we didn't have this check there already. maybe it's always been broken?

@nathanstitt nathanstitt requested a review from a team June 21, 2021 17:44
jivey
jivey approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah maybe we should add an unauthorized course creation user to our e2e tests

@nathanstitt nathanstitt merged commit 378a564 into main Jun 22, 2021
@nathanstitt nathanstitt deleted the no-creat-course branch June 22, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jivey jivey jivey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanstitt @jivey