make data optional as it's already skipped in some events

openstax · Oct 21, 2021 · 33463c0 · 33463c0
1 parent 0e13f6f
commit 33463c0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/tutor/specs/models/user.spec.ts b/tutor/specs/models/user.spec.ts
@@ -30,7 +30,7 @@ describe('User Model', () => {
         expect(User.metrics.course_subjects).toEqual('testing');
         expect(User.metrics.course_types).toEqual('real');
     })
-  
+
     it('calculates audience tags', () => {
         bootstrapCoursesList();
         expect(User.tourAudienceTags).toEqual(['teacher', 'teacher-not-previewed']);
@@ -105,6 +105,11 @@ describe('User Model', () => {
         expect(JSON.parse(body)).toMatchObject({
             some: 'data',
         })
+
+        // Some events do not contain data
+        fetchMock.mockResponseOnce(JSON.stringify({ ok: true }))
+        User.logEvent({ category: 'nodata', code: 'nodata' })
+        expect(fetchMock.mock.calls[1][1]?.body).toBeUndefined()
     }))
 
     it('checks for names then splits', action(() => {

diff --git a/tutor/src/components/my-courses/index.tsx b/tutor/src/components/my-courses/index.tsx
@@ -27,7 +27,7 @@ class MyCourses extends React.Component<MyCoursesProps> {
         if (history && history.action === 'POP') {
             await currentCourses.fetch();
         }
-        currentUser.logEvent({ category: 'onboarding', code: 'arrived_my_courses', data: '' });
+        currentUser.logEvent({ category: 'onboarding', code: 'arrived_my_courses' });
     }
 
     @computed get firstCourse() {

diff --git a/tutor/src/models/user.ts b/tutor/src/models/user.ts
@@ -13,7 +13,7 @@ import urlFor from '../api'
 export interface UserEventPayload {
     category: string
     code: string
-    data: any
+    data?: any
 }