Url jiggering #1579
Merged
Url jiggering #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/DISCO-436
mostly i'm doing this for the correct html_url on blog posts for the impact stories
there were some places in the code that were customizing their urls with only the get_sitemap_urls override, but the documentation recommends using get_url_parts. the url generated by get_url_parts also seems to be used by the sitemap code, so in some place i just removed the sitemap override with the url parts override
removed new subjects feature flag
fixed flex page urls (they were inheriting the
/override from rootpage)marked impact stories and deprecated book index as non-navigable by returning none from url_parts, as suggested in the documentation. weirdly this doesn't omit it from the sitemap, so you need to override that too or None appears in the sitemap
the only places i left the sitemap overrides are where it was generating more than one url or explicitly hiding stuff