Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Blog Content Type snippet and added it to news articles #1269

Merged
merged 14 commits into from
May 10, 2022

Conversation

edwoodward
Copy link
Contributor

@edwoodward edwoodward commented Apr 12, 2022

Search API for Blog Collections, Content Type and Subjects

/apps/cms/api/search/

Parameters:

  • collection - should only be one
  • content_types - comma separated list
  • subjects - comma separated list

Example
/apps/cms/api/search/?collection=OpenStax Updates&content_types=Video,Whitepaper&subjects=Economics,Math

@edwoodward edwoodward self-assigned this Apr 12, 2022
@edwoodward edwoodward requested a review from mwvolo April 12, 2022 15:41
@edwoodward edwoodward added the wip label Apr 13, 2022
@edwoodward edwoodward removed the request for review from mwvolo April 13, 2022 20:09
@edwoodward edwoodward force-pushed the blog-content-types branch 2 times, most recently from 1887d0f to 0ccc82c Compare April 20, 2022 15:06
@edwoodward edwoodward force-pushed the blog-content-types branch 2 times, most recently from 674f4d7 to 01e43fb Compare May 6, 2022 19:19
@edwoodward edwoodward removed the wip label May 6, 2022
@edwoodward edwoodward requested a review from mwvolo May 6, 2022 20:10
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1269 (7dea770) into main (2292d44) will increase coverage by 0.60%.
The diff coverage is 96.40%.

@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
+ Coverage   85.97%   86.57%   +0.60%     
==========================================
  Files         483      490       +7     
  Lines        7535     7771     +236     
==========================================
+ Hits         6478     6728     +250     
+ Misses       1057     1043      -14     

news/search.py Outdated
return JsonResponse(search_results_json, safe=False)
return JsonResponse([], safe=False)
#return JsonResponse([], safe=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@edwoodward edwoodward force-pushed the blog-content-types branch from 78a0c65 to 7afec20 Compare May 10, 2022 13:12
@edwoodward edwoodward merged commit 7206c21 into main May 10, 2022
@edwoodward edwoodward deleted the blog-content-types branch May 10, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants