Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for search engines to IP pages #1182

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

mwvolo
Copy link
Member

@mwvolo mwvolo commented Jul 7, 2021

This fixes an error in Sentry: https://sentry.io/organizations/openstax/issues/2171512829/?project=5594444

It allows search engines and social bots to display more robust previews of pages when linked.

@mwvolo mwvolo requested a review from edwoodward July 7, 2021 17:37
@mwvolo
Copy link
Member Author

mwvolo commented Jul 7, 2021

@edwoodward I'm removing the opportunity tests from the CMS - they would have to be recorded every time the base year changes and I don't think it's worth it. Plus, I hope we can move to use the SF API for creating opps soon (if even needed).
Once this is merged, I'll rebase the other PR so it'll pass tests.

@mwvolo mwvolo merged commit 51a14cc into master Jul 8, 2021
@mwvolo mwvolo deleted the fix-sentry-no-template-error branch July 8, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants