Allow null values for contact id on resource downloads #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: django-doctor[bot] <72320148+django-doctor[bot]@users.noreply.github.com>
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| @@ -331,7 +331,7 @@ class ResourceDownload(models.Model): | |||
| last_access = models.DateTimeField() | |||
| number_of_times_accessed = models.IntegerField() | |||
| resource_name = models.CharField(max_length=255, null=True, blank=False) | |||
| contact_id = models.CharField(max_length=100, blank=True, default='') | |||
| contact_id = models.CharField(max_length=100, null=True, blank=True) | |||
There was a problem hiding this comment.
Suggested change
| contact_id = models.CharField(max_length=100, null=True, blank=True) | |
| contact_id = models.CharField(max_length=100, default='', blank=True) |
null=True on a string field causes inconsistent data types because the value can be either str or None. This adds complexity and maybe bugs, but can be solved by replacing null=True with default="".
RoyEJohnson
reviewed
Jun 29, 2021
|
I would have thought the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.