Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate custom fields and blocks into their own files #1104

Merged
merged 13 commits into from
Dec 10, 2020
Merged

Conversation

mwvolo
Copy link
Member

@mwvolo mwvolo commented Dec 4, 2020

The pages model is getting VERY large - too large.
This breaks out some common functionality into other files to make it more manageable.

Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Worth considering though

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1104 (5711106) into master (25faf2a) will increase coverage by 0.03%.
The diff coverage is 92.24%.

@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
+ Coverage   82.49%   82.52%   +0.03%     
==========================================
  Files         365      369       +4     
  Lines        6377     6388      +11     
==========================================
+ Hits         5261     5272      +11     
  Misses       1116     1116              

@mwvolo mwvolo added the wip label Dec 7, 2020
@mwvolo mwvolo removed the wip label Dec 9, 2020
@mwvolo mwvolo merged commit 695fa41 into master Dec 10, 2020
@mwvolo mwvolo deleted the clean-page-models branch December 10, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants