2232 only newest slugs autocomplete #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new commit and book to test data - Test that the newest commit's books are returned
Probably not needed, but why leave to chance what we can control?
ckline-tryptic
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes openstax/ce#2232
A more long-term solution might be to switch around the version and book input boxes, so that it is intuitive to enter version before book, have version default to main, and have the frontend query for the slugs based on repository and version.
Current version
Lists all books known to have existed in any version of the repository
New version:
Lists books that exist in the newest commit on the repository (regardless of branch)