Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve pagination issue on the register when filtering by the REL tag #3701

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Jan 22, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3690
Fixes #3688

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits changed the title Fix pagination Resolve pagination issue on the register when filtering by the REL tag Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 70 lines in your changes missing coverage. Please review.

Project coverage is 38.5%. Comparing base (61f68b1) to head (8ba715d).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...er/fhircore/engine/data/local/DefaultRepository.kt 23.8% 31 Missing and 1 partial ⚠️
...er/fhircore/quest/ui/register/RegisterViewModel.kt 4.3% 18 Missing and 4 partials ⚠️
...e/engine/data/local/register/RegisterRepository.kt 55.5% 8 Missing ⚠️
...rcore/quest/ui/multiselect/MultiSelectViewModel.kt 0.0% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (23.0%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3701   +/-   ##
=======================================
  Coverage     38.5%   38.5%           
- Complexity    1164    1170    +6     
=======================================
  Files          286     286           
  Lines        15232   15245   +13     
  Branches      2683    2690    +7     
=======================================
+ Hits          5866    5872    +6     
- Misses        8521    8524    +3     
- Partials       845     849    +4     
Flag Coverage Δ
engine 62.7% <33.3%> (+0.1%) ⬆️
geowidget 16.0% <ø> (ø)
quest 24.4% <3.2%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...smartregister/fhircore/quest/data/DataMigration.kt 69.6% <ø> (-0.4%) ⬇️
...e/quest/ui/geowidget/GeoWidgetLauncherViewModel.kt 14.4% <ø> (+<0.1%) ⬆️
...e/engine/data/local/register/RegisterRepository.kt 63.8% <55.5%> (-2.2%) ⬇️
...rcore/quest/ui/multiselect/MultiSelectViewModel.kt 0.0% <0.0%> (ø)
...er/fhircore/quest/ui/register/RegisterViewModel.kt 44.1% <4.3%> (-2.9%) ⬇️
...er/fhircore/engine/data/local/DefaultRepository.kt 63.9% <23.8%> (-1.4%) ⬇️

... and 4 files with indirect coverage changes

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits marked this pull request as ready for review January 28, 2025 08:22
@dubdabasoduba dubdabasoduba merged commit 7da064b into main Jan 29, 2025
4 of 5 checks passed
@dubdabasoduba dubdabasoduba deleted the fix-pagination branch January 29, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants