Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the inner padding config in CompoundText #3589

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

Aleem92
Copy link
Contributor

@Aleem92 Aleem92 commented Nov 5, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (6fc15b0) to head (052645e).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...hircore/quest/ui/shared/components/CompoundText.kt 0.0% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3589     +/-   ##
=========================================
- Coverage     27.1%   27.1%   -0.1%     
  Complexity     775     775             
=========================================
  Files          279     279             
  Lines        14563   14566      +3     
  Branches      2608    2609      +1     
=========================================
  Hits          3957    3957             
- Misses       10065   10068      +3     
  Partials       541     541             
Flag Coverage Δ
engine 63.7% <ø> (ø)
geowidget 16.0% <ø> (ø)
quest 5.7% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ngine/configuration/view/CompoundTextProperties.kt 100.0% <ø> (ø)
...hircore/quest/ui/shared/components/CompoundText.kt 0.0% <0.0%> (ø)

@Aleem92 Aleem92 self-assigned this Nov 5, 2024
@Aleem92 Aleem92 added the Draft label Nov 5, 2024
@Aleem92 Aleem92 force-pushed the compound_text_inner_padding branch from dd208a6 to 9fb60e5 Compare November 6, 2024 17:36
@Aleem92 Aleem92 removed the Draft label Nov 6, 2024
@pld pld merged commit 2b53916 into main Nov 15, 2024
4 of 5 checks passed
@pld pld deleted the compound_text_inner_padding branch November 15, 2024 06:30
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Added the inner padding config in CompoundText

* Unit Tests
asad-zaman pushed a commit to Mpower-social/fhircore-smart-health-bd that referenced this pull request Jan 20, 2025
* Added the inner padding config in CompoundText

* Unit Tests

(cherry picked from commit 2b53916)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CompoundText UI to match the design proposal
2 participants