Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app crash on app launch with location permissions request #3478

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Sep 5, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3477

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (115c4f4) to head (98813bb).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...register/fhircore/quest/ui/main/AppMainActivity.kt 0.0% 37 Missing ⚠️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 0.0% 30 Missing and 2 partials ⚠️
...r/fhircore/engine/util/location/PermissionUtils.kt 0.0% 14 Missing and 2 partials ⚠️
...r/fhircore/quest/ui/shared/QuestionnaireHandler.kt 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3478     +/-   ##
=========================================
- Coverage     27.2%   27.1%   -0.1%     
- Complexity     742     745      +3     
=========================================
  Files          276     275      -1     
  Lines        13811   13917    +106     
  Branches      2504    2527     +23     
=========================================
+ Hits          3764    3782     +18     
- Misses        9540    9611     +71     
- Partials       507     524     +17     
Flag Coverage Δ
engine 64.3% <0.0%> (-0.4%) ⬇️
geowidget 12.5% <ø> (+1.1%) ⬆️
quest 5.5% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ter/fhircore/engine/util/location/LocationUtils.kt 0.0% <ø> (ø)
...r/fhircore/quest/ui/shared/QuestionnaireHandler.kt 14.2% <0.0%> (-2.4%) ⬇️
...r/fhircore/engine/util/location/PermissionUtils.kt 10.0% <0.0%> (+10.0%) ⬆️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 2.7% <0.0%> (+<0.1%) ⬆️
...register/fhircore/quest/ui/main/AppMainActivity.kt 5.0% <0.0%> (+5.0%) ⬆️

... and 6 files with indirect coverage changes

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits merged commit 662acfd into main Sep 6, 2024
4 of 5 checks passed
@ellykits ellykits deleted the fix-app-crash branch September 6, 2024 08:33
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Fix app crash on app launch with location permissions request

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Fix black screen

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

---------

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
asad-zaman pushed a commit to Mpower-social/fhircore-smart-health-bd that referenced this pull request Jan 20, 2025
…p#3478)

* Fix app crash on app launch with location permissions request

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Fix black screen

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

---------

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EUSM] App crashes after login
1 participant