Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock screen orientation to portrait #2707

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Lock screen orientation to portrait #2707

merged 6 commits into from
Aug 25, 2023

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Aug 23, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2704

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2707 (ff22f57) into main (ad3a737) will increase coverage by 0.9%.
Report is 33 commits behind head on main.
The diff coverage is 65.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2707     +/-   ##
=========================================
+ Coverage     64.5%   65.4%   +0.9%     
- Complexity    1075    1103     +28     
=========================================
  Files          218     220      +2     
  Lines         9635    9817    +182     
  Branches      1897    1955     +58     
=========================================
+ Hits          6218    6430    +212     
+ Misses        2234    2133    -101     
- Partials      1183    1254     +71     
Flag Coverage Δ
engine 72.7% <70.6%> (+<0.1%) ⬆️
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 60.5% <64.3%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...hircore/engine/domain/model/FhirResourceConfigs.kt 43.2% <0.0%> (-1.3%) ⬇️
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 80.0% <0.0%> (-2.8%) ⬇️
...ster/fhircore/quest/ui/profile/ProfileViewModel.kt 44.1% <0.0%> (-1.8%) ⬇️
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...rt/measure/models/MeasureReportPopulationResult.kt 25.0% <0.0%> (-12.5%) ⬇️
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 42.8% <14.2%> (-5.6%) ⬇️
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
...ircore/engine/configuration/QuestionnaireConfig.kt 61.0% <30.0%> (-6.4%) ⬇️
...hircore/engine/util/extension/MeasureExtensions.kt 42.5% <31.2%> (-4.6%) ⬇️
... and 24 more

... and 4 files with indirect coverage changes

@ellykits ellykits merged commit f18adc2 into main Aug 25, 2023
@ellykits ellykits deleted the ui-enhancements branch August 25, 2023 11:04
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Lock screen orientation to portrait

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Fix failing test

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

---------

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FHIR Core] - App crashes when a user tilts the device to landscape view.
1 participant