Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue forms saving too slow after Careplan generation #2702

Closed
wants to merge 3 commits into from

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Cherry Picked updates from release branch PR (#2699)

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

* Update release version to v1.0.0
*  Fix issue forms saving too slow
   - Fixes onaio/fhir-resources#2531
@ndegwamartin ndegwamartin changed the title OpenSRP 0.2.5 v1 Fix issue forms saving too slow after Careplan generation Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2702 (ae5ecad) into main (ad3a737) will increase coverage by 0.4%.
Report is 30 commits behind head on main.
The diff coverage is 62.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2702     +/-   ##
=========================================
+ Coverage     64.5%   65.0%   +0.4%     
  Complexity    1075    1075             
=========================================
  Files          218     218             
  Lines         9635    9671     +36     
  Branches      1897    1923     +26     
=========================================
+ Hits          6218    6288     +70     
+ Misses        2234    2158     -76     
- Partials      1183    1225     +42     
Flag Coverage Δ
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 59.9% <62.6%> (+1.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...core/engine/configuration/ConfigurationRegistry.kt 80.3% <ø> (+3.2%) ⬆️
...ircore/engine/configuration/QuestionnaireConfig.kt 67.3% <ø> (ø)
...er/fhircore/engine/data/local/DefaultRepository.kt 69.1% <ø> (-0.1%) ⬇️
...ata/remote/fhir/resource/FhirResourceDataSource.kt 92.8% <ø> (ø)
...ister/fhircore/engine/domain/model/ActionConfig.kt 71.7% <ø> (-0.8%) ⬇️
...ster/fhircore/engine/task/FhirCarePlanGenerator.kt 74.0% <ø> (-0.5%) ⬇️
...smartregister/fhircore/engine/task/FhirTaskUtil.kt 83.3% <ø> (-2.8%) ⬇️
...hircore/engine/util/extension/MeasureExtensions.kt 48.3% <ø> (+1.3%) ⬆️
...ore/engine/util/helper/TransformSupportServices.kt 82.7% <ø> (ø)
...est/data/report/measure/MeasureReportRepository.kt 66.6% <0.0%> (-1.6%) ⬇️
... and 17 more

... and 3 files with indirect coverage changes

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits
Copy link
Collaborator

The tests are failing because we are ignoring the Task.period filter (which is critical otherwise all Tasks will be marked as ready)

@ellykits
Copy link
Collaborator

If the implementation here #2705 improves on performance then we can close this PR (code already in main branch) unless we would want to apply the period filter via code (which would require some significant refactor on the affected test classes)

@ndegwamartin
Copy link
Contributor Author

Closing this PR in favor of #2710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants