Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flavor for the WHO EIR reference app #2696

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Add a flavor for the WHO EIR reference app #2696

merged 3 commits into from
Aug 22, 2023

Conversation

owais-vd
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2690

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@owais-vd owais-vd marked this pull request as draft August 17, 2023 13:11
@owais-vd owais-vd requested a review from dubdabasoduba August 17, 2023 13:12
@owais-vd
Copy link
Contributor Author

@AngelaKabari i've added temporary app icon but require actual icon for this PR cc: @dubdabasoduba

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2696 (253b903) into main (ad3a737) will increase coverage by 0.6%.
Report is 29 commits behind head on main.
The diff coverage is 64.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2696     +/-   ##
=========================================
+ Coverage     64.5%   65.1%   +0.6%     
- Complexity    1075    1100     +25     
=========================================
  Files          218     220      +2     
  Lines         9635    9805    +170     
  Branches      1897    1952     +55     
=========================================
+ Hits          6218    6388    +170     
+ Misses        2234    2171     -63     
- Partials      1183    1246     +63     
Flag Coverage Δ
engine 72.7% <70.4%> (+<0.1%) ⬆️
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 59.9% <62.6%> (+1.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 80.0% <0.0%> (-2.8%) ⬇️
...est/data/report/measure/MeasureReportRepository.kt 66.6% <0.0%> (-1.6%) ⬇️
...ster/fhircore/quest/ui/profile/ProfileViewModel.kt 44.1% <0.0%> (-1.8%) ⬇️
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...rt/measure/models/MeasureReportPopulationResult.kt 25.0% <0.0%> (-12.5%) ⬇️
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 42.8% <14.2%> (-5.6%) ⬇️
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
...ircore/engine/configuration/QuestionnaireConfig.kt 61.0% <30.0%> (-6.4%) ⬇️
...smartregister/fhircore/engine/task/FhirTaskUtil.kt 84.0% <33.3%> (-2.2%) ⬇️
... and 19 more

... and 3 files with indirect coverage changes

@f-odhiambo
Copy link
Contributor

Potential duplicate to #2690

cc @owais-vd @dubdabasoduba @AngelaKabari

@dubdabasoduba
Copy link
Member

Potential duplicate to #2690

cc @owais-vd @dubdabasoduba @AngelaKabari

@f-odhiambo this is the PR to the mentioned issue.

@owais-vd owais-vd marked this pull request as ready for review August 22, 2023 05:54
@owais-vd owais-vd merged commit 3e7a3de into main Aug 22, 2023
@owais-vd owais-vd deleted the issue-2690 branch August 22, 2023 11:47
qiarie pushed a commit that referenced this pull request Jan 15, 2025
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flavor for the WHO EIR reference app
4 participants