Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2642 #2693

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Issue2642 #2693

merged 3 commits into from
Aug 17, 2023

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Closes #2642

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@ndegwamartin ndegwamartin added the Testing Related to testing or testing infrastructure label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2693 (dc6537e) into main (ad3a737) will increase coverage by 0.6%.
Report is 26 commits behind head on main.
The diff coverage is 65.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2693     +/-   ##
=========================================
+ Coverage     64.5%   65.1%   +0.6%     
- Complexity    1075    1089     +14     
=========================================
  Files          218     220      +2     
  Lines         9635    9732     +97     
  Branches      1897    1926     +29     
=========================================
+ Hits          6218    6341    +123     
+ Misses        2234    2164     -70     
- Partials      1183    1227     +44     
Flag Coverage Δ
engine 72.8% <74.5%> (+0.1%) ⬆️
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 59.8% <62.4%> (+0.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 80.0% <0.0%> (-2.8%) ⬇️
...est/data/report/measure/MeasureReportRepository.kt 66.6% <0.0%> (-1.6%) ⬇️
...ster/fhircore/quest/ui/profile/ProfileViewModel.kt 44.1% <0.0%> (-1.8%) ⬇️
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...rt/measure/models/MeasureReportPopulationResult.kt 25.0% <0.0%> (-12.5%) ⬇️
...fhircore/quest/util/extensions/ConfigExtensions.kt 71.8% <0.0%> (ø)
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 42.8% <14.2%> (-5.6%) ⬇️
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
...hircore/engine/util/extension/MeasureExtensions.kt 43.4% <33.3%> (-3.6%) ⬇️
... and 17 more

... and 3 files with indirect coverage changes

@pld pld merged commit c8fb4aa into main Aug 17, 2023
@pld pld deleted the issue2642 branch August 17, 2023 17:50
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Update documentation

* Add Unit Tests ✅

* Clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Related to testing or testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.2.5 Patch to Main Unit Tests
3 participants