Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdverseEvent_SuspectEntity Transform Type #2692

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

qiarie
Copy link
Contributor

@qiarie qiarie commented Aug 17, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@qiarie qiarie requested a review from ndegwamartin August 17, 2023 09:25
@qiarie qiarie marked this pull request as ready for review August 17, 2023 09:26
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2692 (681ad89) into main (ad3a737) will increase coverage by 0.4%.
Report is 24 commits behind head on main.
The diff coverage is 64.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2692     +/-   ##
=========================================
+ Coverage     64.5%   64.9%   +0.4%     
- Complexity    1075    1085     +10     
=========================================
  Files          218     220      +2     
  Lines         9635    9745    +110     
  Branches      1897    1929     +32     
=========================================
+ Hits          6218    6328    +110     
+ Misses        2234    2191     -43     
- Partials      1183    1226     +43     
Flag Coverage Δ
engine 72.5% <72.6%> (-0.2%) ⬇️
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 59.6% <62.4%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...ore/engine/util/helper/TransformSupportServices.kt 80.0% <0.0%> (-2.8%) ⬇️
...est/data/report/measure/MeasureReportRepository.kt 66.6% <0.0%> (-1.6%) ⬇️
...ster/fhircore/quest/ui/profile/ProfileViewModel.kt 44.1% <0.0%> (-1.8%) ⬇️
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...rt/measure/models/MeasureReportPopulationResult.kt 25.0% <0.0%> (-12.5%) ⬇️
...fhircore/quest/util/extensions/ConfigExtensions.kt 71.8% <0.0%> (ø)
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 42.8% <14.2%> (-5.6%) ⬇️
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
...hircore/engine/util/extension/MeasureExtensions.kt 43.4% <33.3%> (-3.6%) ⬇️
... and 17 more

... and 2 files with indirect coverage changes

@qiarie qiarie merged commit c4cd218 into main Aug 17, 2023
@qiarie qiarie deleted the add-adverseevent-suspectentity-type branch August 17, 2023 11:07
qiarie added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants