Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure report format issue fix #2665

Merged
merged 15 commits into from
Aug 15, 2023
Merged

Measure report format issue fix #2665

merged 15 commits into from
Aug 15, 2023

Conversation

maimoonak
Copy link
Contributor

Fixes issue with stratifier data missing from summary report

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

maimoonak added 6 commits June 6, 2023 11:23
# Conflicts:
#	android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirTaskExpireUtil.kt
#	android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirTaskPlanWorker.kt
#	android/engine/src/test/java/org/smartregister/fhircore/engine/task/FhirTaskExpireUtilTest.kt
# Conflicts:
#	android/engine/src/test/java/org/smartregister/fhircore/engine/task/FhirTaskExpireWorkerTest.kt
f-odhiambo
f-odhiambo previously approved these changes Aug 9, 2023
Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolved the issue of measure reports not being generated appropriately, and work as expected. 🥇

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2665 (064df42) into main (ad3a737) will increase coverage by 0.4%.
Report is 20 commits behind head on main.
The diff coverage is 65.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2665     +/-   ##
=========================================
+ Coverage     64.5%   64.9%   +0.4%     
- Complexity    1075    1085     +10     
=========================================
  Files          218     220      +2     
  Lines         9635    9744    +109     
  Branches      1897    1928     +31     
=========================================
+ Hits          6218    6328    +110     
+ Misses        2234    2191     -43     
- Partials      1183    1225     +42     
Flag Coverage Δ
engine 72.6% <73.3%> (-0.2%) ⬇️
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 59.6% <62.4%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...est/data/report/measure/MeasureReportRepository.kt 66.6% <0.0%> (-1.6%) ⬇️
...ster/fhircore/quest/ui/profile/ProfileViewModel.kt 44.1% <0.0%> (-1.8%) ⬇️
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...rt/measure/models/MeasureReportPopulationResult.kt 25.0% <0.0%> (-12.5%) ⬇️
...fhircore/quest/util/extensions/ConfigExtensions.kt 71.8% <0.0%> (ø)
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 42.8% <14.2%> (-5.6%) ⬇️
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
...hircore/engine/util/extension/MeasureExtensions.kt 43.4% <33.3%> (-3.6%) ⬇️
.../quest/ui/report/measure/MeasureReportViewModel.kt 55.7% <44.4%> (+0.1%) ⬆️
... and 16 more

... and 2 files with indirect coverage changes

@f-odhiambo f-odhiambo merged commit b8fef7b into main Aug 15, 2023
@f-odhiambo f-odhiambo deleted the measure-format-fix branch August 15, 2023 12:16
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Fix task scheduling issue

* measure report format issue fix for stratidier

* Fix measure tests

* Fix quest measure tests

---------

Co-authored-by: Francis Odhiambo <4540684+f-odhiambo@users.noreply.github.com>
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants