-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix APK crash for app built on Main branch #2658
Conversation
- Running an app built from main crashes the app after entering App ID
Codecov Report
@@ Coverage Diff @@
## main #2658 +/- ##
=========================================
+ Coverage 64.5% 65.0% +0.5%
- Complexity 1075 1086 +11
=========================================
Files 218 220 +2
Lines 9635 9704 +69
Branches 1897 1910 +13
=========================================
+ Hits 6218 6313 +95
+ Misses 2234 2176 -58
- Partials 1183 1215 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
) | ||
} else | ||
fhirResourceDataSource.post( | ||
"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we provide an empty string as the default to fhirResourceDataSource.post()
path
parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍🏾
...id/quest/src/main/java/org/smartregister/fhircore/quest/ui/appsetting/AppSettingViewModel.kt
Show resolved
Hide resolved
* Fix APK crash for app built on Main branch - Running an app built from main crashes the app after entering App ID - Refactor FhirResourceDataSource.post() to have default Path parameter
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2651
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file