Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APK crash for app built on Main branch #2658

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix APK crash for app built on Main branch #2658

merged 2 commits into from
Aug 9, 2023

Conversation

ndegwamartin
Copy link
Contributor

  • Running an app built from main crashes the app after entering App ID

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2651

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

- Running an app built from main crashes the app after entering App ID
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2658 (9a81ce6) into main (ad3a737) will increase coverage by 0.5%.
Report is 10 commits behind head on main.
The diff coverage is 71.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2658     +/-   ##
=========================================
+ Coverage     64.5%   65.0%   +0.5%     
- Complexity    1075    1086     +11     
=========================================
  Files          218     220      +2     
  Lines         9635    9704     +69     
  Branches      1897    1910     +13     
=========================================
+ Hits          6218    6313     +95     
+ Misses        2234    2176     -58     
- Partials      1183    1215     +32     
Flag Coverage Δ
engine 72.7% <84.4%> (+<0.1%) ⬆️
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 59.7% <69.8%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rcore/engine/util/extension/BigDecimalExtension.kt 0.0% <0.0%> (ø)
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...rt/measure/models/MeasureReportPopulationResult.kt 25.0% <0.0%> (-12.5%) ⬇️
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
.../quest/ui/report/measure/MeasureReportViewModel.kt 54.7% <45.4%> (-0.8%) ⬇️
...re/components/MeasureReportPopulationResultView.kt 76.1% <50.0%> (+0.5%) ⬆️
...hircore/engine/util/extension/MeasureExtensions.kt 48.7% <57.1%> (+1.6%) ⬆️
.../report/measure/screens/MeasureReportListScreen.kt 53.8% <59.0%> (+53.8%) ⬆️
...er/fhircore/engine/data/local/DefaultRepository.kt 69.0% <60.0%> (-0.3%) ⬇️
...ter/fhircore/quest/ui/main/components/AppDrawer.kt 67.8% <67.8%> (-0.9%) ⬇️
... and 9 more

... and 2 files with indirect coverage changes

)
} else
fhirResourceDataSource.post(
"",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we provide an empty string as the default to fhirResourceDataSource.post() path parameter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏾

@ndegwamartin ndegwamartin merged commit 5a1798c into main Aug 9, 2023
@ndegwamartin ndegwamartin deleted the issue2651 branch August 9, 2023 07:57
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Fix APK crash for app built on Main branch
- Running an app built from main crashes the app after entering App ID
- Refactor FhirResourceDataSource.post() to have default Path parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running an app built from main crashes the app after entering App ID
3 participants