Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Sync Progress Implementation (Main) #2572

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Conversation

ndegwamartin
Copy link
Contributor

@ndegwamartin ndegwamartin commented Jul 12, 2023

Closes #2570

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

- Fixes issue where sync progress intermittently resets to zero
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2572 (d971339) into main (d84c2c8) will decrease coverage by 0.3%.
The diff coverage is 61.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2572     +/-   ##
=========================================
- Coverage     65.4%   65.2%   -0.3%     
- Complexity    1101    1117     +16     
=========================================
  Files          213     215      +2     
  Lines         9385    9563    +178     
  Branches      1866    1900     +34     
=========================================
+ Hits          6140    6237     +97     
- Misses        2047    2118     +71     
- Partials      1198    1208     +10     
Flag Coverage Δ
engine 72.8% <66.5%> (-0.3%) ⬇️
geowidget 62.9% <37.5%> (-0.3%) ⬇️
quest 60.3% <58.6%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ter/fhircore/engine/configuration/Configuration.kt 25.0% <ø> (ø)
...ngine/configuration/event/EventTriggerCondition.kt 50.0% <0.0%> (ø)
...ircore/engine/configuration/event/EventWorkflow.kt 33.3% <0.0%> (ø)
...ore/engine/configuration/view/DividerProperties.kt 0.0% <0.0%> (ø)
...ngine/configuration/view/PersonalDataProperties.kt 0.0% <0.0%> (ø)
...hircore/engine/configuration/view/RowProperties.kt 0.0% <ø> (ø)
...ine/configuration/view/ViewPropertiesSerializer.kt 23.8% <0.0%> (ø)
...data/remote/fhir/resource/FhirResourceConverter.kt 100.0% <ø> (ø)
...hircore/engine/domain/model/ActionParameterType.kt 100.0% <ø> (ø)
...hircore/engine/domain/model/FhirResourceConfigs.kt 44.4% <0.0%> (ø)
... and 156 more

... and 11 files with indirect coverage changes

@ndegwamartin ndegwamartin merged commit cc43b64 into main Jul 12, 2023
@ndegwamartin ndegwamartin deleted the sync_reset_zero_main branch July 12, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor inital Sync progress implementation
2 participants