Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.4 RC 4 enhancements PR to main #2564

Merged
merged 9 commits into from
Jul 12, 2023
Merged

0.2.4 RC 4 enhancements PR to main #2564

merged 9 commits into from
Jul 12, 2023

Conversation

ndegwamartin
Copy link
Contributor

@ndegwamartin ndegwamartin commented Jul 11, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

  • Enhances to add support for logging into multiple installed apps with the same username
  • Trim trailing and leading whitespaces in credentials
  • Refactor configs processing implementation to add support for fetching List configuration Composition contents via the FHIR Gateway(Backward Compatible)
  • Bump up release version code to 3

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@ndegwamartin ndegwamartin force-pushed the enhancements+proxy_main branch from 631c083 to ed9f4e4 Compare July 12, 2023 12:36
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2564 (214f412) into main (d84c2c8) will decrease coverage by 0.1%.
The diff coverage is 62.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2564     +/-   ##
=========================================
- Coverage     65.4%   65.3%   -0.1%     
- Complexity    1101    1131     +30     
=========================================
  Files          213     216      +3     
  Lines         9385    9632    +247     
  Branches      1866    1916     +50     
=========================================
+ Hits          6140    6297    +157     
- Misses        2047    2124     +77     
- Partials      1198    1211     +13     
Flag Coverage Δ
engine 73.1% <70.4%> (+<0.1%) ⬆️
geowidget 62.9% <37.5%> (-0.3%) ⬇️
quest 60.3% <57.8%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ter/fhircore/engine/configuration/Configuration.kt 25.0% <ø> (ø)
...ngine/configuration/event/EventTriggerCondition.kt 50.0% <0.0%> (ø)
...ircore/engine/configuration/event/EventWorkflow.kt 33.3% <0.0%> (ø)
...ore/engine/configuration/view/DividerProperties.kt 0.0% <0.0%> (ø)
...ngine/configuration/view/PersonalDataProperties.kt 0.0% <0.0%> (ø)
...hircore/engine/configuration/view/RowProperties.kt 0.0% <ø> (ø)
...ine/configuration/view/ViewPropertiesSerializer.kt 23.8% <0.0%> (ø)
...data/remote/fhir/resource/FhirResourceConverter.kt 100.0% <ø> (ø)
...e/data/remote/fhir/resource/FhirResourceService.kt 0.0% <0.0%> (ø)
...hircore/engine/domain/model/ActionParameterType.kt 100.0% <ø> (ø)
... and 154 more

... and 12 files with indirect coverage changes

@ndegwamartin ndegwamartin force-pushed the enhancements+proxy_main branch from d1b9317 to 7cc7b70 Compare July 12, 2023 13:00
@ndegwamartin ndegwamartin force-pushed the enhancements+proxy_main branch from 7cc7b70 to 8542f1a Compare July 12, 2023 13:02
@ndegwamartin ndegwamartin force-pushed the enhancements+proxy_main branch from 8542f1a to 15679bc Compare July 12, 2023 13:41
@pld pld merged commit 26fcdb7 into main Jul 12, 2023
@pld pld deleted the enhancements+proxy_main branch July 12, 2023 17:16
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Enhances to add support for logging into multiple installed apps with same username

* Trim trailing and leading whitespaces in credentials

* Refactor configs processing implementation
- Add support to fetch List configuration composition contents

* Add backward compatibility for Gateway List Endpoint fetch

* Clean up + Unit Tests ✅
- Unit test Add backward compatibility for Gateway List Endpoint fetch

* Code Refactor/Clean up + Unit Tests ✅

* IS-NON-PROXY flag Documentation 📝

---------

Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants