Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geowidget Fragment tests #2537

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Add Geowidget Fragment tests #2537

merged 12 commits into from
Aug 7, 2023

Conversation

ekigamba
Copy link
Contributor

@ekigamba ekigamba commented Jul 6, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@ekigamba ekigamba requested a review from Rkareko July 6, 2023 13:33
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #2537 (fd16b19) into main (ad3a737) will increase coverage by 0.5%.
Report is 6 commits behind head on main.
The diff coverage is 60.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2537     +/-   ##
=========================================
+ Coverage     64.5%   65.0%   +0.5%     
- Complexity    1075    1079      +4     
=========================================
  Files          218     218             
  Lines         9635    9647     +12     
  Branches      1897    1897             
=========================================
+ Hits          6218    6274     +56     
+ Misses        2234    2168     -66     
- Partials      1183    1205     +22     
Flag Coverage Δ
engine 72.6% <60.0%> (-0.1%) ⬇️
geowidget 65.3% <20.0%> (+1.0%) ⬆️
quest 59.7% <64.4%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 36.6% <20.0%> (+2.4%) ⬆️
...re/components/MeasureReportPopulationResultView.kt 76.1% <50.0%> (+0.5%) ⬆️
.../report/measure/screens/MeasureReportListScreen.kt 53.8% <59.0%> (+53.8%) ⬆️
...er/fhircore/engine/data/local/DefaultRepository.kt 69.0% <60.0%> (-0.3%) ⬇️
...ter/fhircore/quest/ui/main/components/AppDrawer.kt 67.8% <67.8%> (-0.9%) ⬇️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 73.1% <100.0%> (ø)
...re/components/MeasureReportIndividualResultView.kt 75.0% <100.0%> (+1.3%) ⬆️
...eport/measure/screens/MeasureReportResultScreen.kt 66.6% <100.0%> (+66.6%) ⬆️

... and 3 files with indirect coverage changes

@ekigamba ekigamba marked this pull request as ready for review August 7, 2023 12:03
@pld pld merged commit c14be91 into main Aug 7, 2023
@pld pld deleted the kigamba-tt-2021-07-06 branch August 7, 2023 19:01
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Add Geowidget Fragment tests

* Add Geowidget Fragment test

* Fix failing GeowidgetFragment test due to wrong Mapbox SDK token

* Code cleanup with spotlessApply

---------

Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Co-authored-by: Rkareko <47570855+Rkareko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants