Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes & Enhancements #2516

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Fixes & Enhancements #2516

merged 5 commits into from
Jul 3, 2023

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Alternative implementation for to fix #2511

Additional Fixes and Enhancements

  • Add Support For APP ID HTTP Header
  • Enable GZIP by default
  • Disable tagging practitioner details during persistence

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@ndegwamartin ndegwamartin requested review from pld and ellykits July 3, 2023 17:19
pld
pld approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge this, @ndegwamartin do we also want this against main?

@pld pld merged commit 7d71ea5 into opensrp-0.2.4 Jul 3, 2023
@pld pld deleted the fixes-enhance branch July 3, 2023 19:29
@ndegwamartin
Copy link
Contributor Author

Yeah should be ok to merge to main, if we have to use the alternative approach then we'll be forced to refactor all the changes introduced here

ndegwamartin added a commit that referenced this pull request Jul 4, 2023
@ndegwamartin
Fixes & Enhancements (#2516)
cc35fea 
* Add Support For APP ID HTTP Header

* Enable GZIP by default

* Disable tagging practitioner details during persistence

* Refactor Save Remote Resources
- Persist remote resources without flagging as local changes
- Upgrade Engine SDK version

* Add Shared Pref Helper Unit Test
ndegwamartin added a commit that referenced this pull request Jul 4, 2023
@ndegwamartin
Fixes & Enhancements (#2516)
6764f4e 
* Add Support For APP ID HTTP Header

* Enable GZIP by default

* Disable tagging practitioner details during persistence

* Refactor Save Remote Resources
- Persist remote resources without flagging as local changes
- Upgrade Engine SDK version

* Add Shared Pref Helper Unit Test
ndegwamartin added a commit that referenced this pull request Jul 5, 2023
@ndegwamartin
Fixes & Enhancements (#2516) (#2517)
36c6562 
* Fixes & Enhancements (#2516)

- Add Support For APP ID HTTP Header
- Enable GZIP by default
- Disable tagging practitioner details during persistence
- Persist remote resources without flagging as local changes
- Upgrade Engine SDK version
- Add Shared Pref Helper Unit Test
- Add DefaultRepository Unit test
qiarie pushed a commit that referenced this pull request Jan 15, 2025
@ndegwamartin
Fixes & Enhancements (#2516) (#2517)
abe5d3b 
* Fixes & Enhancements (#2516)

- Add Support For APP ID HTTP Header
- Enable GZIP by default
- Disable tagging practitioner details during persistence
- Persist remote resources without flagging as local changes
- Upgrade Engine SDK version
- Add Shared Pref Helper Unit Test
- Add DefaultRepository Unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pld pld pld approved these changes

@ellykits ellykits Awaiting requested review from ellykits

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndegwamartin @pld