Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration to generate MeasureReports in the background #2515

Merged
merged 7 commits into from
Jul 4, 2023

Conversation

roywanyaga
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Closes #[2307]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed on 0.2.4?

@roywanyaga
Copy link
Contributor Author

is this needed on 0.2.4?

Yes, its needed for stock threshold calculations for eCBIS

@roywanyaga roywanyaga requested a review from pld July 4, 2023 06:56
@ndegwamartin ndegwamartin merged commit 30b86df into opensrp-0.2.4 Jul 4, 2023
@ndegwamartin ndegwamartin deleted the 2307-scheduled-report-config branch July 4, 2023 10:05
ndegwamartin added a commit that referenced this pull request Jul 4, 2023
* Add configuration to generate MeasureReports in the background
* Set default report config startPeriod, remove subject from existing measureReport retrieval
* Exclude Subjects from existing measure report retrieval search

---------

Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com>
pld added a commit that referenced this pull request Jul 12, 2023
#2520)

* add configuration to generate MeasureReports in the background (#2515)

* Add configuration to generate MeasureReports in the background
* Set default report config startPeriod, remove subject from existing measureReport retrieval
* Exclude Subjects from existing measure report retrieval search

---------

Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com>

* cleanup and notes

* fix typo

* remove comment

* add a failing test to run eval pop measure

* catch exception with bad measure url

* change MeasureReportConfig to ReportConfiguration, add tests

* upgrade spotless and lint, use trailing commas per new lint recs

---------

Co-authored-by: Roy <84201465+roywanyaga@users.noreply.github.com>
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
qiarie pushed a commit that referenced this pull request Jan 15, 2025
#2520)

* add configuration to generate MeasureReports in the background (#2515)

* Add configuration to generate MeasureReports in the background
* Set default report config startPeriod, remove subject from existing measureReport retrieval
* Exclude Subjects from existing measure report retrieval search

---------

Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com>

* cleanup and notes

* fix typo

* remove comment

* add a failing test to run eval pop measure

* catch exception with bad measure url

* change MeasureReportConfig to ReportConfiguration, add tests

* upgrade spotless and lint, use trailing commas per new lint recs

---------

Co-authored-by: Roy <84201465+roywanyaga@users.noreply.github.com>
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants