-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add configuration to generate MeasureReports in the background #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pld
reviewed
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed on 0.2.4?
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
…easureReport retrieval
Yes, its needed for stock threshold calculations for eCBIS |
…rcore into 2307-scheduled-report-config merge opensrp-0.2.4 into 2307-scheduled-report-config
ndegwamartin
approved these changes
Jul 4, 2023
ndegwamartin
added a commit
that referenced
this pull request
Jul 4, 2023
* Add configuration to generate MeasureReports in the background * Set default report config startPeriod, remove subject from existing measureReport retrieval * Exclude Subjects from existing measure report retrieval search --------- Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com>
pld
added a commit
that referenced
this pull request
Jul 12, 2023
#2520) * add configuration to generate MeasureReports in the background (#2515) * Add configuration to generate MeasureReports in the background * Set default report config startPeriod, remove subject from existing measureReport retrieval * Exclude Subjects from existing measure report retrieval search --------- Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com> * cleanup and notes * fix typo * remove comment * add a failing test to run eval pop measure * catch exception with bad measure url * change MeasureReportConfig to ReportConfiguration, add tests * upgrade spotless and lint, use trailing commas per new lint recs --------- Co-authored-by: Roy <84201465+roywanyaga@users.noreply.github.com> Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com> Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
qiarie
pushed a commit
that referenced
this pull request
Jan 15, 2025
#2520) * add configuration to generate MeasureReports in the background (#2515) * Add configuration to generate MeasureReports in the background * Set default report config startPeriod, remove subject from existing measureReport retrieval * Exclude Subjects from existing measure report retrieval search --------- Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com> * cleanup and notes * fix typo * remove comment * add a failing test to run eval pop measure * catch exception with bad measure url * change MeasureReportConfig to ReportConfiguration, add tests * upgrade spotless and lint, use trailing commas per new lint recs --------- Co-authored-by: Roy <84201465+roywanyaga@users.noreply.github.com> Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com> Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Closes #[2307]
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file