Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync timestamp not updating #2514

Merged
merged 8 commits into from
Jul 4, 2023
Merged

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Jun 30, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/opensrp/fhir-resources/issues/520

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

ellykits added 4 commits June 29, 2023 15:20
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits changed the base branch from opensrp-0.2.4 to main June 30, 2023 15:20
@ellykits ellykits added the DNM DO NOT MERGE label Jun 30, 2023
@ellykits ellykits marked this pull request as draft June 30, 2023 15:20
@ellykits ellykits marked this pull request as ready for review July 3, 2023 09:09
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #2514 (a381fc3) into main (2ea8fa1) will increase coverage by 0.3%.
The diff coverage is 61.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2514     +/-   ##
=========================================
+ Coverage     64.8%   65.2%   +0.3%     
- Complexity    1050    1085     +35     
=========================================
  Files          209     213      +4     
  Lines         9156    9353    +197     
  Branches      1805    1863     +58     
=========================================
+ Hits          5942    6105    +163     
+ Misses        2059    2051      -8     
- Partials      1155    1197     +42     
Flag Coverage Δ
engine 72.8% <59.4%> (-0.3%) ⬇️
geowidget 63.2% <ø> (ø)
quest 60.3% <63.8%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/engine/configuration/view/ColumnProperties.kt 100.0% <ø> (ø)
...ore/engine/configuration/view/DividerProperties.kt 0.0% <0.0%> (ø)
...ine/configuration/view/ViewPropertiesSerializer.kt 23.8% <0.0%> (-2.6%) ⬇️
...e/engine/ui/bottomsheet/RegisterBottomSheetView.kt 51.2% <0.0%> (-2.5%) ⬇️
...g/smartregister/fhircore/quest/QuestApplication.kt 44.2% <ø> (+0.8%) ⬆️
...er/fhircore/quest/ui/shared/components/CardView.kt 81.0% <ø> (ø)
...hircore/quest/ui/shared/components/CompoundText.kt 75.2% <0.0%> (-0.9%) ⬇️
...fhircore/quest/util/extensions/ConfigExtensions.kt 67.1% <0.0%> (-2.9%) ⬇️
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 33.3% <6.6%> (+13.3%) ⬆️
...core/engine/configuration/view/ButtonProperties.kt 48.8% <33.3%> (-3.4%) ⬇️
... and 36 more

... and 5 files with indirect coverage changes

ellykits added 2 commits July 3, 2023 14:18
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ndegwamartin ndegwamartin removed the DNM DO NOT MERGE label Jul 4, 2023
@ndegwamartin ndegwamartin merged commit 5e97ee2 into main Jul 4, 2023
@ndegwamartin ndegwamartin deleted the fix-sync-timestamp-not-updating branch July 4, 2023 09:14
@ndegwamartin ndegwamartin removed the 0.2.4 label Jul 4, 2023
@ndegwamartin ndegwamartin restored the fix-sync-timestamp-not-updating branch July 4, 2023 09:31
@ndegwamartin ndegwamartin deleted the fix-sync-timestamp-not-updating branch July 4, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants