-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overdue service status #2507
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2507 +/- ##
=========================================
+ Coverage 64.8% 65.2% +0.3%
- Complexity 1050 1086 +36
=========================================
Files 209 212 +3
Lines 9156 9353 +197
Branches 1805 1859 +54
=========================================
+ Hits 5942 6104 +162
+ Misses 2059 2057 -2
- Partials 1155 1192 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Timber.e("Task.status is null", Exception()) | ||
ServiceStatus.DUE.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we need to use the DUE state here. It's already used when task status is READY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I think I will make them UPCOMING. Since it seems like the task is not ready to be worked on if it's on hold
1e38a1b
to
c7ad1a1
Compare
* Add the Service Card color test * 🐛 Fix overdue status 0.2.4 * ⏪ Remove unwated tests * ✨ Mark all the non ready, in-progres, requested, completed or cancelled as UPCOMING * null tasks are upcoming --------- Co-authored-by: pld <peter@ona.io>
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes https://github.com/opensrp/fhir-resources/issues/1736
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file