Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16550: UPSTREAM: 2511: Bump github.com/elazarl/goproxy to fix CVE-2023-37788 #95

Conversation

mpatlasov
Copy link

@mpatlasov mpatlasov commented Oct 19, 2023

The content of this patch resulted from:

$ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor

where f99041a5c is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788

Release note:

CVE-2023-37788 is fixed by bumping `github.com/elazarl/goproxy` version

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 19, 2023
@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-16550, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The content of this patch resulted from:

$ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor

where f99041a5c is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged.
The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc.
For new features, new tests should be done, in addition to regression tests.
If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject.
The review cycle will start, only after "[WIP]" is removed from the PR subject.

Special notes for your reviewer:

Release note:

CVE-2023-37788 is fixed by bumping `github.com/elazarl/goproxy` version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@mpatlasov
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-16550, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 19, 2023
@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-16550, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from radeore October 19, 2023 21:01
@mpatlasov mpatlasov changed the title OCPBUGS-16550: UPSTREAM: 2511: Bump github.com/elazarl/goproxy to fix CVE-2023-37788 UPSTREAM: 2511: OCPBUGS-16550: Bump github.com/elazarl/goproxy to fix CVE-2023-37788 Oct 19, 2023
@mpatlasov
Copy link
Author

/test verify-commits

@mpatlasov mpatlasov changed the title UPSTREAM: 2511: OCPBUGS-16550: Bump github.com/elazarl/goproxy to fix CVE-2023-37788 OCPBUGS-16550: UPSTREAM: 2511: Bump github.com/elazarl/goproxy to fix CVE-2023-37788 Oct 19, 2023
…VE-2023-37788

The content of this patch resulted from:
```
$ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor
```
where `f99041a5c` is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788
@mpatlasov mpatlasov force-pushed the fix-goproxy-CVE-2023-37788-downstream branch from a916ee7 to 52460b1 Compare October 19, 2023 21:05
@mpatlasov
Copy link
Author

/test e2e-vsphere-csi
/test e2e-vsphere
/test e2e-vsphere-ovn-upgrade
/test e2e-vsphere-csi-extended

mpatlasov added a commit to mpatlasov/vmware-vsphere-csi-driver that referenced this pull request Oct 20, 2023
A bunch of tests in [PR#95](openshift#95) failed with:

```
* 2023-10-19T22:06:34Z 1x kubelet: Started container place-entrypoint
* 2023-10-19T22:08:02Z 4x kubelet: Pulling image "registry.ci.openshift.org/ci/entrypoint-wrapper:latest"
* 2023-10-19T22:08:03Z 4x kubelet: Failed to pull image "registry.ci.openshift.org/ci/entrypoint-wrapper:latest": rpc error: code = Unknown desc = fetching target platform image selected from manifest list: reading manifest sha256:23c4b21ba4577aa5dca9820c64498101ca6ab99be3bbb312cc0d96ff0d69268f in registry.ci.openshift.org/ci/entrypoint-wrapper: manifest unknown
* 2023-10-19T22:08:03Z 4x kubelet: Error: ErrImagePull
* 2023-10-19T22:07:51Z 5x kubelet: Back-off pulling image "registry.ci.openshift.org/ci/entrypoint-wrapper:latest"
* 2023-10-19T22:07:51Z 5x kubelet: Error: ImagePullBackOff
```

Let's look if it's reproducible with this NOOP PR.
@mpatlasov
Copy link
Author

Some tests are perma-failing. See how they failed in NOOP PR here: #96 (comment) .

/override ci/prow/e2e-vsphere-csi-extended
/override ci/prow/e2e-vsphere-csi
/override ci/prow/e2e-vsphere-ovn-upgrade
/override ci/prow/e2e-vsphere

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

@mpatlasov: Overrode contexts on behalf of mpatlasov: ci/prow/e2e-vsphere, ci/prow/e2e-vsphere-csi, ci/prow/e2e-vsphere-csi-extended, ci/prow/e2e-vsphere-ovn-upgrade

In response to this:

Some tests are perma-failing. See how they failed in NOOP PR here: #96 (comment) .

/override ci/prow/e2e-vsphere-csi-extended
/override ci/prow/e2e-vsphere-csi
/override ci/prow/e2e-vsphere-ovn-upgrade
/override ci/prow/e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit ac7f4d3 into openshift:master Nov 10, 2023
@openshift-ci-robot
Copy link

@mpatlasov: Jira Issue OCPBUGS-16550: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16550 has been moved to the MODIFIED state.

In response to this:

The content of this patch resulted from:

$ go get -u github.com/elazarl/goproxy@f99041a5c0273fcf6a144498b458a630585872f; go mod tidy; go mod vendor

where f99041a5c is commit-id corresponding to elazarl/goproxy#507 which resolved CVE-2023-37788

Release note:

CVE-2023-37788 is fixed by bumping `github.com/elazarl/goproxy` version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.15.0-0.nightly-2023-11-13-174800

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build vmware-vsphere-syncer-container-v4.15.0-202311202349.p0.gac7f4d3.assembly.stream for distgit vmware-vsphere-syncer.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants