Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DevConsole integration tests to the appropriate package #3195

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Move DevConsole integration tests to the appropriate package #3195

merged 1 commit into from
Nov 9, 2019

Conversation

vojtechszocs
Copy link
Contributor

With #2051 merged, Console plugins can now declare new (or extend existing) test suites.

Files related to devconsole suite were moved to packages/dev-console/integration-tests.

cc @spadgett @christianvogt

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2019
@christianvogt
Copy link
Contributor

@vojtechszocs thanks for doing this

@vojtechszocs
Copy link
Contributor Author

Looks like I've missed some ESLint errors 😃 will update.

@vojtechszocs vojtechszocs force-pushed the move-devconsole-integration-tests branch from 10fe678 to a0a14a1 Compare November 4, 2019 18:28
@vojtechszocs
Copy link
Contributor Author

@christianvogt PR updated & added packages/dev-console/integration-tests/.eslintrc.js file.

@vojtechszocs
Copy link
Contributor Author

/retest

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt
Copy link
Contributor

/test e2e-gcp-console

2 similar comments
@christianvogt
Copy link
Contributor

/test e2e-gcp-console

@vojtechszocs
Copy link
Contributor Author

/test e2e-gcp-console

@vojtechszocs
Copy link
Contributor Author

/retest

@spadgett spadgett added this to the v4.3 milestone Nov 6, 2019
@spadgett
Copy link
Member

spadgett commented Nov 6, 2019

/retest

1 similar comment
@spadgett
Copy link
Member

spadgett commented Nov 6, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@andrewballantyne
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@christianvogt
Copy link
Contributor

/test e2e-gcp-console

@spadgett
Copy link
Member

spadgett commented Nov 9, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit bf755ca into openshift:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@sahil143 sahil143 Awaiting requested review from sahil143

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
7 participants
@vojtechszocs @christianvogt @openshift-ci-robot @spadgett @openshift-bot @andrewballantyne @openshift-merge-robot