Bug 1718052: Do not log OAuth tokens in audit logs #205
Conversation
Even the metadata level is not safe as metadata.name is the secret. Signed-off-by: Monis Khan <mkhan@redhat.com>
openshift-ci-robot
added
the
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, enj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherrypick release-4.1 |
|
@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
enj
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@enj: This pull request references a valid Bugzilla bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: new pull request created: #206 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick approved |
|
@deads2k: cannot checkout approved: error checking out approved: exit status 1. output: error: pathspec 'approved' did not match any file(s) known to git. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Even the metadata level is not safe as metadata.name is the secret.
Signed-off-by: Monis Khan mkhan@redhat.com
@deads2k